Change in openvpn[master]: GHA: Update mbedtls to v4
A message that is not in the archive (sent off-list or not yet received): gerrit.1768409585000.I658b1b24da304938225a8f834d7484671a63360f@...2715...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1474?usp=email
to review the following change.
Change subject: GHA: Update mbedtls to v4
......................................................................
GHA: Update mbedtls to v4
Also switch from Make to CMake for building it
because the former is not supported anymore.
---
M .github/workflows/build.yaml
1 file changed, 12 insertions(+), 8 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/74/1474/1
.github/workflows/build.yaml +12 -8
@@ -366,12 +366,12 @@ - name: make check run: make -j3 check VERBOSE=1 - mbedtls3: + mbedtls4: strategy: fail-fast: false matrix: os: [ubuntu-22.04] - ssllib: [mbedtls3] + ssllib: [mbedtls4] build: [ normal, asan ] include: - build: asan
@@ -398,15 +398,19 @@ uses: actions/[email protected]... # v5.0.1 with: path: mbedtls - submodules: true + submodules: recursive # versioning=semver-coerced repository: Mbed-TLS/mbedtls - ref: v3.6.5 - - name: "mbedtls: make no_test" - run: make -j3 no_test SHARED=1 + ref: v4.0.0 + - uses: lukka/[email protected]... # v4.1.1 + - name: "mbedtls: cmake" + run: cmake -B build working-directory: mbedtls - - name: "mbedtls: make install" - run: sudo make install DESTDIR=/usr + - name: "mbedtls: cmake --build" + run: cmake --build build + working-directory: mbedtls + - name: "mbedtls: cmake --install" + run: sudo cmake --install build --prefix /usr working-directory: mbedtls - name: Checkout OpenVPN uses: actions/[email protected]... # v5.0.1
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1474?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I658b1b24da304938225a8f834d7484671a63360f
Gerrit-Change-Number: 1474
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Attention is currently required from: flichtenheld, plaisthos.
uddr has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1474?usp=email )
Change subject: GHA: Update mbedtls to v4
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1474?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I658b1b24da304938225a8f834d7484671a63360f
Gerrit-Change-Number: 1474
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-Reviewer: uddr <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Wed, 14 Jan 2026 20:22:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, uddr,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1474?usp=email
to look at the new patch set (#2).
The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now.
Change subject: GHA: Update mbedtls to v4
......................................................................
GHA: Update mbedtls to v4
Also switch from Make to CMake for building it
because the former is not supported anymore.
---
M .github/workflows/build.yaml
1 file changed, 12 insertions(+), 8 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/74/1474/2
.github/workflows/build.yaml +12 -8
@@ -366,12 +366,12 @@ - name: make check run: make -j3 check VERBOSE=1 - mbedtls3: + mbedtls4: strategy: fail-fast: false matrix: os: [ubuntu-22.04] - ssllib: [mbedtls3] + ssllib: [mbedtls4] build: [ normal, asan ] include: - build: asan
@@ -398,15 +398,19 @@ uses: actions/[email protected]... # v6.0.1 with: path: mbedtls - submodules: true + submodules: recursive # versioning=semver-coerced repository: Mbed-TLS/mbedtls - ref: v3.6.5 - - name: "mbedtls: make no_test" - run: make -j3 no_test SHARED=1 + ref: v4.0.0 + - uses: lukka/[email protected]... # v4.1.1 + - name: "mbedtls: cmake" + run: cmake -B build working-directory: mbedtls - - name: "mbedtls: make install" - run: sudo make install DESTDIR=/usr + - name: "mbedtls: cmake --build" + run: cmake --build build + working-directory: mbedtls + - name: "mbedtls: cmake --install" + run: sudo cmake --install build --prefix /usr working-directory: mbedtls - name: Checkout OpenVPN uses: actions/[email protected]... # v6.0.1
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1474?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I658b1b24da304938225a8f834d7484671a63360f
Gerrit-Change-Number: 1474
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-Reviewer: uddr <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
PATCH v2 1/1 GHA: Update mbedtls to v4
In reply to a message not in the archiveFrom: Frank Lichtenheld <[email protected]...>
Also switch from Make to CMake for building it
because the former is not supported anymore.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1474
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1474
This mail reflects revision 2 of this Change.
Acked-by according to Gerrit (reflected above):
Yuriy Darnobyt <[email protected]...>
.github/workflows/build.yaml +12 -8
@@ -366,12 +366,12 @@ - name: make check run: make -j3 check VERBOSE=1 - mbedtls3: + mbedtls4: strategy: fail-fast: false matrix: os: [ubuntu-22.04] - ssllib: [mbedtls3] + ssllib: [mbedtls4] build: [ normal, asan ] include: - build: asan
@@ -398,15 +398,19 @@ uses: actions/[email protected]... # v6.0.1 with: path: mbedtls - submodules: true + submodules: recursive # versioning=semver-coerced repository: Mbed-TLS/mbedtls - ref: v3.6.5 - - name: "mbedtls: make no_test" - run: make -j3 no_test SHARED=1 + ref: v4.0.0 + - uses: lukka/[email protected]... # v4.1.1 + - name: "mbedtls: cmake" + run: cmake -B build working-directory: mbedtls - - name: "mbedtls: make install" - run: sudo make install DESTDIR=/usr + - name: "mbedtls: cmake --build" + run: cmake --build build + working-directory: mbedtls + - name: "mbedtls: cmake --install" + run: sudo cmake --install build --prefix /usr working-directory: mbedtls - name: Checkout OpenVPN uses: actions/[email protected]... # v6.0.1
[Openvpn-devel] [PATCH applied] Re: GHA: Update mbedtls to v4
Tested via GHA :-) - and lo and behold, it builds mbedtls4 builds, and those succeed...! (The mbedtls4 builds replace the "legacy" mbedtls3 builds - we have those in BB)
No actual code change for OpenVPN, just build instructions for GH.
The mbedtls4 builds now do build the test suite as well (our mbedtls3 builds didn't) - not sure if that can be avoided, but it takes quite a bit of time...
Your patch has been applied to the master branch.
commit c7fbd8a302ac679d2fead0c70dcfff61ce953c47
Author: Frank Lichtenheld Date: Sat Jan 24 19:18:07 2026 +0100
GHA: Update mbedtls to v4
Signed-off-by: Frank Lichtenheld <[email protected]...>
Acked-by: Yuriy Darnobyt <[email protected]...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1474
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg35421.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
cron2 has uploaded a new patch set (#3) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1474?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by uddr
Change subject: GHA: Update mbedtls to v4
......................................................................
GHA: Update mbedtls to v4
Also switch from Make to CMake for building it
because the former is not supported anymore.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1474
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg35421.html
---
M .github/workflows/build.yaml
1 file changed, 12 insertions(+), 8 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/74/1474/3
.github/workflows/build.yaml +12 -8
@@ -366,12 +366,12 @@ - name: make check run: make -j3 check VERBOSE=1 - mbedtls3: + mbedtls4: strategy: fail-fast: false matrix: os: [ubuntu-22.04] - ssllib: [mbedtls3] + ssllib: [mbedtls4] build: [ normal, asan ] include: - build: asan
@@ -398,15 +398,19 @@ uses: actions/[email protected]... # v6.0.1 with: path: mbedtls - submodules: true + submodules: recursive # versioning=semver-coerced repository: Mbed-TLS/mbedtls - ref: v3.6.5 - - name: "mbedtls: make no_test" - run: make -j3 no_test SHARED=1 + ref: v4.0.0 + - uses: lukka/[email protected]... # v4.1.1 + - name: "mbedtls: cmake" + run: cmake -B build working-directory: mbedtls - - name: "mbedtls: make install" - run: sudo make install DESTDIR=/usr + - name: "mbedtls: cmake --build" + run: cmake --build build + working-directory: mbedtls + - name: "mbedtls: cmake --install" + run: sudo cmake --install build --prefix /usr working-directory: mbedtls - name: Checkout OpenVPN uses: actions/[email protected]... # v6.0.1
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1474?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I658b1b24da304938225a8f834d7484671a63360f
Gerrit-Change-Number: 1474
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-Reviewer: uddr <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1474?usp=email )
Change subject: GHA: Update mbedtls to v4
......................................................................
GHA: Update mbedtls to v4
Also switch from Make to CMake for building it
because the former is not supported anymore.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1474
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg35421.html
---
M .github/workflows/build.yaml
1 file changed, 12 insertions(+), 8 deletions(-)
.github/workflows/build.yaml +12 -8
@@ -366,12 +366,12 @@ - name: make check run: make -j3 check VERBOSE=1 - mbedtls3: + mbedtls4: strategy: fail-fast: false matrix: os: [ubuntu-22.04] - ssllib: [mbedtls3] + ssllib: [mbedtls4] build: [ normal, asan ] include: - build: asan
@@ -398,15 +398,19 @@ uses: actions/[email protected]... # v6.0.1 with: path: mbedtls - submodules: true + submodules: recursive # versioning=semver-coerced repository: Mbed-TLS/mbedtls - ref: v3.6.5 - - name: "mbedtls: make no_test" - run: make -j3 no_test SHARED=1 + ref: v4.0.0 + - uses: lukka/[email protected]... # v4.1.1 + - name: "mbedtls: cmake" + run: cmake -B build working-directory: mbedtls - - name: "mbedtls: make install" - run: sudo make install DESTDIR=/usr + - name: "mbedtls: cmake --build" + run: cmake --build build + working-directory: mbedtls + - name: "mbedtls: cmake --install" + run: sudo cmake --install build --prefix /usr working-directory: mbedtls - name: Checkout OpenVPN uses: actions/[email protected]... # v6.0.1
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1474?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I658b1b24da304938225a8f834d7484671a63360f
Gerrit-Change-Number: 1474
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-Reviewer: uddr <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>